[release/9.0-staging] [debugger] Fix a step that becomes a go #110533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mikelle-rogers <[email protected]>
ghost
added
the
tommcdon
approved these changes
Dec 9, 2024
|
Tagging subscribers to this area: @tommcdon |
jeffschwMSFT
approved these changes
Dec 9, 2024
Open
3 tasks
thaystg
added
Servicing-approved
|
Approved by email |
|
/ba-g Build analysis blocked by #110517 |
This was referenced Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110484 to release/9.0-staging
/cc @thaystg
Customer Impact
#109785
#109812
#109885
The customer is stepping over (F10) / into (F11) using the Visual Studio Debugger and suddenly a step becomes a go, only on Windows. In our testing, the issue reproduces approximately 1 out of 100 steps. The issue is caused by APC's (Asynchronous Procedure Calls), which can happen any time during code execution and can randomly interfere with the debuggers stepping logic.
There is no workaround for the customer other than downgrading to .NET 8. APC's (Asynchronous Procedure Calls) were enabled by default in .NET 9 and cannot be disabled.
Regression
This was working on .NET 8, and happened more frequently when we enable APC by default.
Testing
The test was manually done following the customer example, and also using the internal tests where we could also reproduce it, we ran more than 2000 times and no failures were seen anymore.
Risk
Medium risk, we tested a lot but this may cause any weird behavior where we should disable the single step and we are not disabling anymore.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.